feat: create course home api DRF (#33173) (#33204) #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrey-canon
force-pushed
the
and/backport_home_api
branch
7 times, most recently
from
75c8900 to
342b469
Compare
johanseto
approved these changes
May 8, 2024
| @@ -18,6 +19,7 @@ class HomePageViewTest(CourseTestCase): | |||
| """ | |||
| Tests for HomePageView. | |||
| """ | |||
| MODULESTORE = TEST_DATA_SPLIT_MODULESTORE | |||
There was a problem hiding this comment.
This add new modulestore, the next commit add the import xD
There was a problem hiding this comment.
My mistake I made a interactive rebase a this line was moved from the other commit
| @@ -65,7 +67,7 @@ def test_home_page_response(self): | |||
| } | |||
|
|
|||
| self.assertEqual(response.status_code, status.HTTP_200_OK) | |||
| self.assertDictEqual(expected_response, response.data) | |||
| self.assertDictEqual(expected_response, json.loads(json.dumps(response.data))) | |||
There was a problem hiding this comment.
Interesting, I think the response.data is in disorder so the json manipulation order it?
There was a problem hiding this comment.
Nop, the problem was that literally in palm appears an OrderedDict so that raises an error because a dict is dict different from an orderedDict
andrey-canon
force-pushed
the
and/backport_home_api
branch
from
342b469 to
23fe279
Compare
andrey-canon
force-pushed
the
and/backport_tagging
branch
from
8c770b5 to
e9ac94d
Compare
andrey-canon
changed the base branch from
and/backport_tagging
to
open-release/palm.nelp
andrey-canon
force-pushed
the
and/backport_home_api
branch
from
23fe279 to
7d8f3a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of openedx#33173
There are two extra commits
How to test
/api/contentstore/v1/course_rerun/<course-id>/api/contentstore/v1/home